On Tue, 30 Jul 2019 15:29:41 -0700 Divya Indi <divya.i...@oracle.com> wrote:
> Hi Steven, > > On 7/29/19 5:51 PM, Steven Rostedt wrote: > > On Mon, 29 Jul 2019 17:02:34 -0700 > > Divya Indi <divya.i...@oracle.com> wrote: > > > >> Use "trace_array_set_clr_event" to enable/disable events to a trace > >> array from other kernel modules/components. > >> Hence, we no longer need to have ftrace_set_clr_event as an exported API. > > Hmm, this simply reverts patch 1. Why have patch 1 and this patch in > > the first place? > > Right! First patch fixes issues in a previous commit and then this patch > reverts the part of previous commit that required the fix. > > We can eliminate the first patch if it seems counter intuitive. > > As a stand alone patch, the first one may be fine. But as part of a series, it doesn't make sense to add it. -- Steve
