On 8/7/19 7:59 AM, Stephen Boyd wrote:
Quoting Guenter Roeck (2019-08-07 06:58:34)
On Fri, Aug 02, 2019 at 03:27:54PM -0700, Stephen Boyd wrote:
Quoting Hung-Te Lin (2019-08-02 01:20:31)
-static int vpd_section_attrib_add(const u8 *key, s32 key_len,
- const u8 *value, s32 value_len,
+static int vpd_section_attrib_add(const u8 *key, u32 key_len,
+ const u8 *value, u32 value_len,
void *arg)
{
int ret;
@@ -246,7 +246,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
static int vpd_sections_init(phys_addr_t physaddr)
{
- struct vpd_cbmem *temp;
+ struct vpd_cbmem __iomem *temp;
The change to __iomem should also be a separate patch.
Please don't change it back to __iomem. See commit ae21f41e1f56
("firmware: vpd: Drop __iomem usage for memremap() memory") for why.
Sorry, I didn't notice that part.
Guenter
