On Mon, Aug 12, 2019 at 1:07 PM Joe Perches <[email protected]> wrote:
>
> Add another test for __attribute__((section("foo"))) uses
> that should be __section(foo)
>
> Suggested-by: Nick Desaulniers <[email protected]>
> Signed-off-by: Joe Perches <[email protected]>
> Tested-by: Nick Desaulniers <[email protected]> # post PEBKAC <smile>
lol please don't commit that (PEBKAC)
> ---
> scripts/checkpatch.pl | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 1cdacb4fd207..d4153b81b1eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5901,6 +5901,18 @@ sub process {
> "__aligned(size) is preferred over
> __attribute__((aligned(size)))\n" . $herecurr);
> }
>
> +# Check for __attribute__ section, prefer __section
> + if ($realfile !~ m@\binclude/uapi/@ &&
> + $line =~
> /\b__attribute__\s*\(\s*\(.*_*section_*\s*\(\s*("[^"]*")/) {
> + my $old = substr($rawline, $-[1], $+[1] - $-[1]);
> + my $new = substr($old, 1, -1);
> + if (WARN("PREFER_SECTION",
> + "__section($new) is preferred over
> __attribute__((section($old)))\n" . $herecurr) &&
> + $fix) {
> + $fixed[$fixlinenr] =~
> s/\b__attribute__\s*\(\s*\(\s*_*section_*\s*\(\s*\Q$old\E\s*\)\s*\)/__section($new)/;
> + }
> + }
> +
> # Check for __attribute__ format(printf, prefer __printf
> if ($realfile !~ m@\binclude/uapi/@ &&
> $line =~
> /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
>
>
--
Thanks,
~Nick Desaulniers
