On Fri, Aug 16, 2019 at 06:31:55PM +0200, Hubert Feurstein wrote: > > int __mdiobus_read(struct mii_bus *bus, int addr, u32 regnum); > int __mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val); > +int __mdiobus_write_sts(struct mii_bus *bus, int addr, u32 regnum, u16 val, > + struct ptp_system_timestamp *sts); > > int mdiobus_read(struct mii_bus *bus, int addr, u32 regnum); > int mdiobus_read_nested(struct mii_bus *bus, int addr, u32 regnum); > int mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val); > int mdiobus_write_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val); > +int mdiobus_write_sts(struct mii_bus *bus, int addr, u32 regnum, u16 val, > + struct ptp_system_timestamp *sts); > +int mdiobus_write_sts_nested(struct mii_bus *bus, int addr, u32 regnum, u16 > val, > + struct ptp_system_timestamp *sts);
Following the pattern, you have made three new global mdiobus_write_sts() functions. However, your patch set only uses mdiobus_write_sts_nested(). Please don't add global functions with no users. Let the first user add them, if and when the need arises. Thanks, Richard
