On 8/19/19 4:15 PM, René van Dorst wrote: > Hi Tao, > > Quoting Tao Ren <[email protected]>: > >> On 8/11/19 4:40 PM, Tao Ren wrote: >>> From: Heiner Kallweit <[email protected]> >>> >>> This patch adds support for clause 37 1000Base-X auto-negotiation. >>> >>> Signed-off-by: Heiner Kallweit <[email protected]> >>> Signed-off-by: Tao Ren <[email protected]> >> >> A kind reminder: could someone help to review the patch when you have >> bandwidth? >> > > FWIW: I have a similar setup with my device. MAC -> PHY -> SFP cage. > PHY is a Qualcomm at8031 and is used as a RGMII-to-SerDes converter. > SerDes only support 100Base-FX and 1000Base-X in this converter mode. > PHY also supports a RJ45 port but that is not wired on my device. > > I converted [0] at803x driver to make use of the PHYLINK API for SFP cage and > also of these new c37 functions. > > In autoneg on and off, it detects the link and can ping a host on the network. > Tested with 1gbit BiDi optical(1000Base-X) and RJ45 module(SGMII). > Both work and both devices detects unplug and plug-in of the cable. > > output of ethtool: > > Autoneg on > Settings for lan5: > Supported ports: [ TP MII ] > Supported link modes: 100baseT/Half 100baseT/Full > 1000baseT/Full > 1000baseX/Full > Supported pause frame use: Symmetric Receive-only > Supports auto-negotiation: Yes > Supported FEC modes: Not reported > Advertised link modes: 100baseT/Half 100baseT/Full > 1000baseT/Full > 1000baseX/Full > Advertised pause frame use: Symmetric Receive-only > Advertised auto-negotiation: Yes > Advertised FEC modes: Not reported > Link partner advertised link modes: 1000baseX/Full > Link partner advertised pause frame use: Symmetric Receive-only > Link partner advertised auto-negotiation: Yes > Link partner advertised FEC modes: Not reported > Speed: 1000Mb/s > Duplex: Full > Port: MII > PHYAD: 7 > Transceiver: internal > Auto-negotiation: on > Supports Wake-on: g > Wake-on: d > Link detected: yes > > Autoneg off > Settings for lan5: > Supported ports: [ TP MII ] > Supported link modes: 100baseT/Half 100baseT/Full > 1000baseT/Full > 1000baseX/Full > Supported pause frame use: Symmetric Receive-only > Supports auto-negotiation: Yes > Supported FEC modes: Not reported > Advertised link modes: 1000baseT/Full > Advertised pause frame use: Symmetric Receive-only > Advertised auto-negotiation: No > Advertised FEC modes: Not reported > Speed: 1000Mb/s > Duplex: Full > Port: MII > PHYAD: 7 > Transceiver: internal > Auto-negotiation: off > Supports Wake-on: g > Wake-on: d > Link detected: yes > > Tested-by: René van Dorst <[email protected]> > > Greats, > > René
Great. Thank you for the testing, René. Cheers, Tao
