On Wed, 28 Aug 2019 14:51:00 -0500, Josh Poimboeuf said: > > The real question then becomes - should the Makefile sanitize CFLAGS or just > > append to whatever the user supplied as it does currently? The rest of the > > tree > > sanitizes CFLAG, because I don't get deluged in -Wsign-compare warnings all > > over the place... > > Agreed. I assume this fixes it? > > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile > index 88158239622b..20f67fcf378d 100644
> -CFLAGS += -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) > $(LIBELF_FLAGS) > +CFLAGS := -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) > $(LIBELF_FLAGS) Yep, thanks. Feel free to stick these on the final version: Reported-by: Valdis Kletnieks <[email protected]> Tested-by: Valdis Kletnieks <[email protected]>
