Hi Dan, On Thu, Aug 29, 2019 at 06:11:44PM +0300, Dan Carpenter wrote: > On Thu, Aug 29, 2019 at 01:18:10PM +0200, Greg Kroah-Hartman wrote: > > It could always use more review, which the developers asked for > > numerous times. > > I stopped commenting on erofs style because all the likely/unlikely() > nonsense is a pet peeve.
I don't know what is wrong for EROFS to use unlikely for all error handling path (that is what IS_ERR implys). If you like, I will delete them all. p.s. There are 2947 (un)likely places in fs/ directory. Thanks, Gao Xiang > > regards, > dan carpenter >
