On Fri, Aug 30, 2019 at 12:04:41AM +0800, Gao Xiang wrote: > Anyway, I'm fine to delete them all if you like, but I think majority of these > are meaningful. > > data.c- /* page is already locked */ > data.c- DBG_BUGON(PageUptodate(page)); > data.c- > data.c: if (unlikely(err)) > data.c- SetPageError(page); > data.c- else > data.c- SetPageUptodate(page);
If we cared about speed here then we would delete the DBG_BUGON() check because that's going to be expensive. The likely/unlikely annotations should be used in places a reasonable person thinks it will make a difference to benchmarks. regards, dan carpenter
