Hi!

> Reading /sys/class/leds/<led>/trigger returns all available LED triggers.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute.
> 
> Enabling LED CPU trigger on systems with thousands of CPUs easily hits
> PAGE_SIZE limit, and makes it impossible to see all available LED triggers
> and which trigger is currently activated.
> 
> This converts /sys/class/leds/<led>/trigger to bin attribute and removes
> the PAGE_SIZE limitation.
> 
> Cc: Jacek Anaszewski <jacek.anaszew...@gmail.com>

Nothing obviously wrong from a quick look...

Acked-by: Pavel Machek <pa...@ucw.cz>

Thanks a lot for doing this!

I believe we should cc Greg here.

BTW if you care about cpuled trigger... it would be cool to turn it into one 
trigger and pass
a cpu number as a parameter. It is good to see this limit fixed, but real 
solution is to
register one trigger per driver.

Best regards,
                                                                                
Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Reply via email to