Thanks Andy, sorry for the inconvenience, I will check the log more carefully next time.
On Mon, Sep 2, 2019 at 3:48 PM Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > > > On Tuesday, September 3, 2019, Yizhuo <yzhai...@ucr.edu> wrote: >> >> In function axp288_extcon_log_rsi(), variable "val" could be >> uninitialized if regmap_read() fails. However, it's ued to >> decide the control flow later in the if statement, which is >> potentially unsafe. > > > https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=d72e3dc7915fc6c54645772c13f4afc0e676c7e2 > >> >> Signed-off-by: Yizhuo <yzhai...@ucr.edu> >> --- >> drivers/extcon/extcon-axp288.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c >> index 7254852e6ec0..54116a926ab6 100644 >> --- a/drivers/extcon/extcon-axp288.c >> +++ b/drivers/extcon/extcon-axp288.c >> @@ -135,6 +135,11 @@ static void axp288_extcon_log_rsi(struct >> axp288_extcon_info *info) >> int ret; >> >> ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val); >> + if (ret) { >> + dev_err(info->dev, "failed to read >> AXP288_PS_BOOT_REASON_REG\n"); >> + return; >> + } >> + >> for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) { >> if (val & BIT(i)) { >> dev_dbg(info->dev, "%s\n", *rsi); >> -- >> 2.17.1 >> > > > -- > With Best Regards, > Andy Shevchenko > > -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of California, Riverside
