> On Wed, Sep 04, 2019 at 10:02:54PM +0800, Voon Weifeng wrote: > > From: "Chuah, Kim Tatt" <kim.tatt.ch...@intel.com> > > > > DW EQoS v5.xx controllers added capability for interrupt generation > > when MDIO interface is done (GMII Busy bit is cleared). > > This patch adds support for this interrupt on supported HW to avoid > > polling on GMII Busy bit. > > > > stmmac_mdio_read() & stmmac_mdio_write() will sleep until wake_up() is > > called by the interrupt handler. > > > > Reviewed-by: Voon Weifeng <weifeng.v...@intel.com> > > Reviewed-by: Kweh, Hock Leong <hock.leong.k...@intel.com> > > Reviewed-by: Ong Boon Leong <boon.leong....@intel.com> > > Signed-off-by: Chuah, Kim Tatt <kim.tatt.ch...@intel.com> > > Signed-off-by: Ong Boon Leong <boon.leong....@intel.com> > > Signed-off-by: Voon Weifeng <weifeng.v...@intel.com> > > Hi Voon > > It is normal to include a short description of what you changed between > the previous version and this version.
The change log is near the end of the patch: /** -- Changelog v2 *mdio interrupt mode or polling mode will depends on mdio interrupt enable bit *Disable the mdio interrupt enable bit in stmmac_release *Remove the condition for initialize wait queues *Applied reverse Christmas tree 1.9.1 > > The formatting of this patch also looks a bit odd. Did you use git > format-patch ; git send-email? Yes, I do git format-patch, then ./scripts/checkpatch.pl. Lastly git send-email > > Thanks > Andrew
