> > The change log is near the end of the patch: > > /** > > -- > > Changelog v2 > > *mdio interrupt mode or polling mode will depends on mdio interrupt > > enable bit *Disable the mdio interrupt enable bit in stmmac_release > > *Remove the condition for initialize wait queues *Applied reverse > > Christmas tree > > 1.9.1 > > At the end, nobody sees it, because everybody else does it at the > beginning. > > https://www.kernel.org/doc/html/latest/process/submitting- > patches.html?highlight=submitting#the-canonical-patch-format > > This talks about the ---. David prefers to see the change log before the > ---. Other maintainers want it after the ---. > > > > > > > > > The formatting of this patch also looks a bit odd. Did you use git > > > format-patch ; git send-email? > > > > Yes, I do git format-patch, then ./scripts/checkpatch.pl. > > Lastly git send-email > > What looked odd is the missing --- marker. git format-patch should of > create that as part of the patch. > > Andrew
I found out why as I did a git format-patch with -p which is without the Stat. I will resent v3 to using correct format. Weifeng
