Hi Neil,
On 2019/9/11 23:54, Neil Armstrong wrote:
> On 11/09/2019 17:38, Jianxin Pan wrote:
>> Add basic support for the Amlogic A1 based Amlogic AD401 board:
>> which describe components as follows: Reserve Memory, CPU, GIC, IRQ,
>> Timer, UART. It's capable of booting up into the serial console.
>>
>> Signed-off-by: Jianxin Pan <jianxin....@amlogic.com>
>> Reviewed-by: Jerome Brunet <jbru...@baylibre.com>
>> ---
>> arch/arm64/boot/dts/amlogic/Makefile | 1 +
>> arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts | 30 ++++++
>> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 131
>> +++++++++++++++++++++++++
>> 3 files changed, 162 insertions(+)
[...]
>> +
>> + sm: secure-monitor {
>> + compatible = "amlogic,meson-gxbb-sm";
>> + };
>> +
>> + soc {
>> + compatible = "simple-bus";
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> +
>> + apb: bus@0xfe000000 {
>
> Should be bus@fe000000
>
Thanks for your review.
I resent a new version and fixed it.
>> + compatible = "simple-bus";
>> + reg = <0x0 0xfe000000 0x0 0x1000000>;
>> + #address-cells = <2>;
>> + #size-cells = <2>;
[...]
>> + xtal: xtal-clk {
>> + compatible = "fixed-clock";
>> + clock-frequency = <24000000>;
>> + clock-output-names = "xtal";
>> + #clock-cells = <0>;
>> + };
>> +};
>>
>
> With that fixed:
> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com>
>
> Neil
>
> .
>
