On Thu, 2019-09-12 at 09:08 -0400, Benjamin Coddington wrote: > On 12 Sep 2019, at 8:53, Trond Myklebust wrote: > > Let's please just scrap this function and rewrite it as a generic > > function for reading the MIC. It clearly is not a generic function > > for > > reading arbitrary netobjs, and modifications like the above just > > make > > the misnomer painfully obvious. > > > > Let's rewrite it as xdr_buf_read_mic() so that we can simplify it > > where > > possible. > > Ok. I want to assume the mic will not land in the head, but I am not > sure.. > Is there a scenario where the mic might land in the head, or is that > bit of > the current function left over from other uses?
It is likely to land in the head for most RPC calls that have short replies. Particularly in error cases. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.mykleb...@hammerspace.com
