On Mon, Sep 23, 2019 at 04:10:36PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Sep 13, 2019 at 03:23:14PM +0200, Jiri Olsa escreveu: > > We need page_size in libperf, so moving it in there. > > Adding libperf_init as a global libperf init functon. > > > > Link: http://lkml.kernel.org/n/tip-g6auuaej31nsusuevuhcg...@git.kernel.org > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > > --- > > tools/perf/lib/core.c | 7 +++++++ > > tools/perf/lib/include/internal/lib.h | 2 ++ > > tools/perf/lib/include/perf/core.h | 1 + > > tools/perf/lib/lib.c | 2 ++ > > tools/perf/lib/libperf.map | 1 + > > tools/perf/perf.c | 4 ++-- > > tools/perf/util/util.h | 2 -- > > you forgot to remove it from tools/perf/util/util.c, I did it, and also > added internal/lib.h to the places that use page_size, after this I'll > remove that include from util/util.h, that header has to die :-)
ah right.. linker wouldn't fail because it's variable, so there's no conflict.. thanks, jirka
