On 9/30/19 10:54 PM, Thomas Hellstrom wrote: > Hi, > > On 9/18/19 7:57 PM, Dave Hansen wrote: >> On 9/17/19 6:01 AM, Thomas Hellström (VMware) wrote: >>> diff --git a/arch/x86/include/asm/pgtable_types.h >>> b/arch/x86/include/asm/pgtable_types.h >>> index b5e49e6bac63..8267dd426b15 100644 >>> --- a/arch/x86/include/asm/pgtable_types.h >>> +++ b/arch/x86/include/asm/pgtable_types.h >>> @@ -123,7 +123,7 @@ >>> */ >>> #define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | >>> \ >>> _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY | \ >>> - _PAGE_SOFT_DIRTY | _PAGE_DEVMAP) >>> + _PAGE_SOFT_DIRTY | _PAGE_DEVMAP | _PAGE_ENC) >>> #define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE) >> My only nit with what remains is that it expands the infestation of >> things that look like a simple macro but are not. >> >> I'm debating whether we want to go fix that now, though. >> > Any chance for an ack on this? It's really a small change that, as we've > found out, fixes an existing problem.
Yes, feel free to add: Reviewed-by: Dave Hansen <dave.han...@linux.intel.com>
