Hi Dan, I love your patch! Yet something to improve:
[auto build test ERROR on j.anaszewski-leds/for-next] [cannot apply to v5.4-rc1 next-20191001] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework/20191002-062337 base: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git for-next config: x86_64-randconfig-f004-201939 (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <[email protected]> All errors (new ones prefixed by >>): ld: drivers/leds/leds-lp55xx-common.o: in function `lp55xx_set_brightness': >> drivers/leds/leds-lp55xx-common.c:158: undefined reference to >> `led_mc_calc_brightness' ld: drivers/leds/leds-lp55xx-common.o: in function `led_classdev_multicolor_register': >> include/linux/led-class-multicolor.h:64: undefined reference to >> `led_classdev_multicolor_register_ext' vim +158 drivers/leds/leds-lp55xx-common.c 147 148 static int lp55xx_set_brightness(struct led_classdev *cdev, 149 enum led_brightness brightness) 150 { 151 struct lp55xx_led *led = cdev_to_lp55xx_led(cdev); 152 struct lp55xx_device_config *cfg = led->chip->cfg; 153 int channel_num; 154 int ret; 155 int i; 156 157 if (led->mc_cdev.num_leds > 1) { > 158 led_mc_calc_brightness(&led->mc_cdev, brightness, 159 &color_component[0]); 160 161 for (i = 0; i < led->mc_cdev.num_leds; i++) { 162 channel_num = lp55xx_get_channel(led, 163 color_component[i].color_id); 164 if (channel_num < 0) 165 return channel_num; 166 167 ret = cfg->color_intensity_fn(led, channel_num, 168 color_component[i].brightness); 169 if (ret) 170 return ret; 171 } 172 } else { 173 led->brightness = (u8)brightness; 174 ret = cfg->brightness_fn(led); 175 } 176 177 return ret; 178 } 179 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
