On 9/13/19 2:07 AM, Abhishek Goel wrote:
Cpupower tool has set and info options which are being used only by x86 machines. This patch removes support for these two subcommands from generic cpupower utility. Thus, these two subcommands will now be available only for intel. This removes the ambiguous error message while using set option in case of using non-intel systems.Without this patch on a non-intel box: root@ubuntu:~# cpupower info System does not support Intel's performance bias setting root@ubuntu:~# cpupower set -b 10 Error setting perf-bias value on CPU With this patch on a non-intel box: root@ubuntu:~# cpupower info Supported commands are: frequency-info frequency-set idle-info idle-set monitor help Same result for set subcommand. This patch does not affect results on a intel box. Signed-off-by: Abhishek Goel <[email protected]> Acked-by: Thomas Renninger <[email protected]> --- changes from v1: Instead of bailing out early in set and info commands, in V2, we are cutting out support for these two commands for non-intel systems.
thanks. I will get this in for 5.4-rc3 veru likely. Definitely in 5.4 -- Shuah
