Hi Michal and Greg, > -----Original Message----- > From: Michal Simek <michal.si...@xilinx.com> > Sent: Sunday, October 06, 2019 11:14 PM > To: Greg KH <gre...@linuxfoundation.org>; Jolly Shah <jol...@xilinx.com> > Cc: ard.biesheu...@linaro.org; mi...@kernel.org; m...@codeblueprint.co.uk; > sudeep.ho...@arm.com; hkallwe...@gmail.com; keesc...@chromium.org; > dmitry.torok...@gmail.com; Michal Simek <mich...@xilinx.com>; Rajan Vaja > <raj...@xilinx.com>; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal > firmware > > On 04. 10. 19 18:18, Greg KH wrote: > > On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote: > >> ZynqMP firmware driver can be used for versal also. > >> Add versal compatible string to zynqmp firmware driver > >> doc. > >> > >> Signed-off-by: Jolly Shah <jolly.s...@xilinx.com> > >> --- > >> .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 > +++++++++++++++- > >> 1 file changed, 15 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp- > firmware.txt > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp- > firmware.txt > >> index a4fe136..18c3aea 100644 > >> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp- > firmware.txt > >> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp- > firmware.txt > >> @@ -11,7 +11,9 @@ power management service, FPGA service and other > platform management > >> services. > >> > >> Required properties: > >> - - compatible: Must contain: "xlnx,zynqmp-firmware" > >> + - compatible: Must contain any of below: > >> + "xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC > >> + "xlnx,versal-firmware" for Versal > >> - method: The method of calling the PM-API firmware layer. > >> Permitted values are: > >> - "smc" : SMC #0, following the SMCCC > >> @@ -21,6 +23,8 @@ Required properties: > >> Example > >> ------- > >> > >> +Zynq Ultrascale+ MPSoC > >> +---------------------- > >> firmware { > >> zynqmp_firmware: zynqmp-firmware { > >> compatible = "xlnx,zynqmp-firmware"; > >> @@ -28,3 +32,13 @@ firmware { > >> ... > >> }; > >> }; > >> + > >> +Versal > >> +------ > >> +firmware { > >> + versal_firmware: versal-firmware { > >> + compatible = "xlnx,versal-firmware"; > >> + method = "smc"; > >> + ... > >> + }; > >> +}; > >> -- > >> 2.7.4 > >> > > > > > > For new dt bindings, don't you have to cc: the dt maintainers and > > mailing list? I can't take the patch until I get an ack from them. > > Yes dt guys should be in CC and normally I am taking this via ARM soc tree. > > Jolly: Please resend >
Sorry missed it earlier. Sent v2 including DT maintainers. Thanks, Jolly Shah > Thanks, > Michal