On Tue, 2019-10-08 at 11:40 +0200, Geert Uytterhoeven wrote:
> When reading a patch file from standard input, checkpatch calls it "Your
> patch", and reports its state as:
>
> Your patch has style problems, please review.
>
> or:
>
> Your patch has no obvious style problems and is ready for submission.
>
> Hence when checking multiple patches by piping them to checkpatch, e.g.
> when checking patchwork bundles using:
>
> formail -s scripts/checkpatch.pl < bundle-foo.mbox
>
> it is difficult to identify which patches need to be reviewed and
> improved.
>
> Fix this by replacing "Your patch" by the patch subject, if present.
Seems sensible, thanks Geert
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
> scripts/checkpatch.pl | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb0880830..6b9feb4d646a116b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1047,6 +1047,10 @@ for my $filename (@ARGV) {
> }
> while (<$FILE>) {
> chomp;
> + if ($vname eq 'Your patch') {
> + my ($subject) = $_ =~ /^Subject:\s*(.*)/;
> + $vname = '"' . $subject . '"' if $subject;
trivia:
Not a big deal and is likely good enough but this will
cut off subjects that are continued on multiple lines.
e.g.:
Subject: [PATCH Vx n/M] very long description with a subject spanning
multiple lines
From: patch submitter <submit...@domain.tld>
> + }
> push(@rawlines, $_);
> }
> close($FILE);
