Hi Joe, I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing] [cannot apply to v5.4-rc2 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Joe-Perches/ipmi-Convert-ipmi_debug_msg-to-pr_debug-and-use-ph/20191014-051352 config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: drivers/char/ipmi/ipmi_msghandler.c: In function 'i_ipmi_request': >> include/linux/kern_levels.h:5:18: warning: field width specifier '*' expects >> argument of type 'int', but argument 4 has type 'unsigned char *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:2251:3: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:2251:18: note: format string is defined here pr_debug("%s: %*ph\n", ~^~ In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: >> include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of >> type 'void *', but argument 5 has type 'int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:2251:3: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:2251:19: note: format string is defined here pr_debug("%s: %*ph\n", ~~^ %*d In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: drivers/char/ipmi/ipmi_msghandler.c: In function 'handle_ipmb_get_msg_cmd': >> include/linux/kern_levels.h:5:18: warning: field width specifier '*' expects >> argument of type 'int', but argument 4 has type 'unsigned char *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:3715:3: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:3715:18: note: format string is defined here pr_debug("%s: %*ph\n", ~^~ In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: >> include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of >> type 'void *', but argument 5 has type 'int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:3715:3: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:3715:19: note: format string is defined here pr_debug("%s: %*ph\n", ~~^ %*d In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: drivers/char/ipmi/ipmi_msghandler.c: In function 'handle_one_recv_msg': >> include/linux/kern_levels.h:5:18: warning: field width specifier '*' expects >> argument of type 'int', but argument 4 has type 'unsigned char *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4203:2: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", "Recv", msg->rsp, msg->rsp_size); ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4203:17: note: format string is defined here pr_debug("%s: %*ph\n", "Recv", msg->rsp, msg->rsp_size); ~^~ In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: >> include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of >> type 'void *', but argument 5 has type 'int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4203:2: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", "Recv", msg->rsp, msg->rsp_size); ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4203:18: note: format string is defined here pr_debug("%s: %*ph\n", "Recv", msg->rsp, msg->rsp_size); ~~^ %*d In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: drivers/char/ipmi/ipmi_msghandler.c: In function 'smi_from_recv_msg': >> include/linux/kern_levels.h:5:18: warning: field width specifier '*' expects >> argument of type 'int', but argument 4 has type 'unsigned char *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4562:2: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", "Resend", smi_msg->data, smi_msg->data_size); ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4562:17: note: format string is defined here pr_debug("%s: %*ph\n", "Resend", smi_msg->data, smi_msg->data_size); ~^~ In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/char/ipmi/ipmi_msghandler.c:17: >> include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of >> type 'void *', but argument 5 has type 'int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:137:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4562:2: note: in expansion of macro 'pr_debug' pr_debug("%s: %*ph\n", "Resend", smi_msg->data, smi_msg->data_size); ^~~~~~~~ drivers/char/ipmi/ipmi_msghandler.c:4562:18: note: format string is defined here pr_debug("%s: %*ph\n", "Resend", smi_msg->data, smi_msg->data_size); ~~^ %*d vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 :::::: The code at line 5 was first introduced by commit :::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern :::::: TO: Joe Perches <j...@perches.com> :::::: CC: Linus Torvalds <torva...@linux-foundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
