Hi Dan, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on iio/togreg] [cannot apply to v5.4-rc3 next-20191014] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dan-Robertson/dt-bindings-iio-accel-bma400-add-bindings/20191014-034052 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> smatch warnings: drivers/iio/accel/bma400_core.c:422 bma400_set_accel_oversampling_ratio() warn: unsigned 'acc_config' is never less than zero. vim +/acc_config +422 drivers/iio/accel/bma400_core.c 404 405 static int bma400_set_accel_oversampling_ratio(struct bma400_data *data, 406 int val) 407 { 408 int ret; 409 unsigned int acc_config; 410 411 if (val & ~BMA400_TWO_BITS_MASK) 412 return -EINVAL; 413 414 /* 415 * The oversampling ratio is stored in a different register 416 * based on the power-mode. 417 */ 418 switch (data->power_mode) { 419 case POWER_MODE_LOW: 420 ret = regmap_read(data->regmap, BMA400_ACC_CONFIG0_REG, 421 &acc_config); > 422 if (acc_config < 0) 423 return acc_config; 424 425 ret = regmap_write(data->regmap, BMA400_ACC_CONFIG0_REG, 426 (acc_config & ~BMA400_LP_OSR_MASK) | 427 (val << BMA400_LP_OSR_SHIFT)); 428 if (ret < 0) { 429 dev_err(data->dev, "Failed to write out OSR"); 430 return ret; 431 } 432 433 data->oversampling_ratio = val; 434 return 0; 435 case POWER_MODE_NORMAL: 436 ret = regmap_read(data->regmap, BMA400_ACC_CONFIG1_REG, 437 &acc_config); 438 if (ret < 0) 439 return ret; 440 441 ret = regmap_write(data->regmap, BMA400_ACC_CONFIG1_REG, 442 (acc_config & ~BMA400_NP_OSR_MASK) | 443 (val << BMA400_NP_OSR_SHIFT)); 444 if (ret < 0) { 445 dev_err(data->dev, "Failed to write out OSR"); 446 return ret; 447 } 448 449 data->oversampling_ratio = val; 450 return 0; 451 default: 452 return -EINVAL; 453 } 454 return ret; 455 } 456 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
