On Mon, Oct 07, 2019 at 04:47:20PM -0700, Sami Tolvanen wrote: > On Mon, Oct 7, 2019 at 2:34 PM Nick Desaulniers <ndesaulni...@google.com> > wrote: > > Should the definition of the ALTERNATIVE macro > > (arch/arm64/include/asm/alternative.h#L295) also be updated in this > > patch to not pass `1` as the final parameter? > > No, that's the default value for cfg in case the caller omits the > parameter, and it's still needed. > > > I get one error on linux-next that looks related: > > $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang AS=clang > > -j71 arch/arm64/kvm/ > > ... > > This patch only touches the inline assembly version (i.e. when > compiling without -no-integrated-as), while with AS=clang you are > using clang also for stand-alone assembly code. I believe some > additional work is needed before we can do that.
Is there any benefit from supporting '-no-integrated-as' but not 'AS=clang'? afaict, you have to hack the top-level Makefile for that. Will