> -----Original Message-----
> From: 'Christoph Hellwig' <h...@infradead.org>
> Sent: Tuesday, October 15, 2019 2:36 PM
> To: Pankaj Dubey <pankaj.du...@samsung.com>
> Cc: 'Christoph Hellwig' <h...@infradead.org>; linux-...@vger.kernel.org;
linux-
> ker...@vger.kernel.org; bhelg...@google.com; andrew.mur...@arm.com;
> lorenzo.pieral...@arm.com; gustavo.pimen...@synopsys.com;
> jingooh...@gmail.com; vid...@nvidia.com; 'Anvesh Salveru'
> <anves...@samsung.com>
> Subject: Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related
equalization
> quirks
>
> On Tue, Oct 15, 2019 at 02:28:00PM +0530, Pankaj Dubey wrote:
> > Is this something mandatory?
> >
> > As we discussed during first patch-set here [1] with Andrew, we have
> > need of this patch (along with some other stuffs, which will be sent
> > soon), to clean up our internal driver and make it ready for upstream.
> > As of today we have some internal restrictions where we can't make it
> > to upstream along with this patch.
>
> We don't add code to the kernel without actual users.
OK, but do we think the current driver has only code which is being used by
some user?
At least I can see current driver has some features which is not being used
by any current driver.
I will leave this call up-to the maintainers.
IMO, This being an DWC H/W IP feature, for me it makes sense to have it in
DWC controller driver as long as it does not break any existing
functionality, irrespective of actual user is present or not.
