On 2019/10/17 17:20, huangdaode wrote: > Hi Marc > I am just doing the coccicheck using the command "make coccicheck > M=drivers/irqchip/", and it report > $ make coccicheck M=drivers/irqchip/ > ....... > drivers/irqchip//irq-mvebu-icu.c:361:1-10: WARNING: Use > devm_platform_ioremap_resource for icu -> base > drivers/irqchip//irq-ts4800.c:105:1-11: WARNING: Use > devm_platform_ioremap_resource for data -> base > drivers/irqchip//irq-mvebu-pic.c:134:1-10: WARNING: Use > devm_platform_ioremap_resource for pic -> base > drivers/irqchip//irq-ti-sci-inta.c:571:1-11: WARNING: Use > devm_platform_ioremap_resource for inta -> base > drivers/irqchip//irq-stm32-exti.c:853:1-16: WARNING: Use > devm_platform_ioremap_resource for host_data -> base > > so just fix the WARNING. > > And after apply the patch, I do the compile, it's OK, but I lack of hardware > to test it. > That's the case. > > MBR. > Thanks > > -----邮件原件----- > 发件人: Marc Zyngier [mailto:[email protected]] > 发送时间: 2019年10月17日 16:24 > 收件人: huangdaode <[email protected]> > 抄送: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > 主题: Re: [PATCH] use devm_platform_ioremap_resource() for irqchip drivers > > On 2019-10-17 08:13, Daode Huang wrote: >> From: Daode Huang <[email protected]> >> >> Use the new helper that wraps the calls to platform_get_resource() and >> devm_ioremap_resource() together >> >> Signed-off-by: Daode Huang <[email protected]> >> --- >> drivers/irqchip/irq-mvebu-icu.c | 3 +-- >> drivers/irqchip/irq-mvebu-pic.c | 3 +-- >> drivers/irqchip/irq-stm32-exti.c | 3 +-- >> drivers/irqchip/irq-ti-sci-inta.c | 3 +-- >> drivers/irqchip/irq-ts4800.c | 3 +-- >> 5 files changed, 5 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/irqchip/irq-mvebu-icu.c >> b/drivers/irqchip/irq-mvebu-icu.c index 547045d..ddf9b0d 100644 >> --- a/drivers/irqchip/irq-mvebu-icu.c >> +++ b/drivers/irqchip/irq-mvebu-icu.c >> @@ -357,8 +357,7 @@ static int mvebu_icu_probe(struct platform_device >> *pdev) >> >> icu->dev = &pdev->dev; >> >> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - icu->base = devm_ioremap_resource(&pdev->dev, res); >> + icu->base = devm_platform_ioremap_resource(pdev, res);
It should be : + icu->base = devm_platform_ioremap_resource(pdev, 0); > > void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev, > unsigned int index) > > What could possibly go wrong? I'd suggest you start compiling (and possibly > testing) the code you change before sending patches... > > M. > -- > Jazz is not dead. It just smells funny... >
