if misc_register() fails, previously allocated data is left without freeing,
this could result in memory leak.

So fix it!

Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org>
---
 drivers/misc/fastrpc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index e3e085e33d46..9065d3e71ff7 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1613,8 +1613,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device 
*rpdev)
                                            domains[domain_id]);
        data->miscdev.fops = &fastrpc_fops;
        err = misc_register(&data->miscdev);
-       if (err)
+       if (err) {
+               kfree(data);
                return err;
+       }
 
        kref_init(&data->refcount);
 
-- 
2.21.0

Reply via email to