From: Vasily Averin <v...@virtuozzo.com>

[ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ]

If seq_file .next function does not change position index, read after
some lseek can generate unexpected output.

https://bugzilla.kernel.org/show_bug.cgi?id=206283
Signed-off-by: Vasily Averin <v...@virtuozzo.com>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
Acked-by: Peter Oberparleiter <ober...@linux.ibm.com>
Cc: Al Viro <v...@zeniv.linux.org.uk>
Cc: Davidlohr Bueso <d...@stgolabs.net>
Cc: Ingo Molnar <mi...@redhat.com>
Cc: Manfred Spraul <manf...@colorfullife.com>
Cc: NeilBrown <ne...@suse.com>
Cc: Steven Rostedt <rost...@goodmis.org>
Cc: Waiman Long <long...@redhat.com>
Link: 
http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4f...@virtuozzo.com
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 kernel/gcov/fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index edf67c493a8e1..e473f6a1f6ca7 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void 
*data, loff_t *pos)
 {
        struct gcov_iterator *iter = data;
 
+       (*pos)++;
        if (gcov_iter_next(iter))
                return NULL;
-       (*pos)++;
 
        return iter;
 }
-- 
2.20.1



Reply via email to