This "goto" doesn't reduce any code, but bother the readers.

Signed-off-by: Zhen Lei <thunder.leiz...@huawei.com>
---
 mm/page_io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_io.c b/mm/page_io.c
index 76965be1d40e..b1d4f4558e6b 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -235,10 +235,10 @@ int generic_swapfile_activate(struct swap_info_struct 
*sis,
        sis->highest_bit = page_no - 1;
 out:
        return ret;
+
 bad_bmap:
        pr_err("swapon: swapfile has holes\n");
-       ret = -EINVAL;
-       goto out;
+       return -EINVAL;
 }
 
 /*
-- 
2.26.0.106.g9fadedd


Reply via email to