On Tue, May 5, 2020 at 9:09 PM Steven Rostedt <rost...@goodmis.org> wrote:
>
>
> You keep forgetting to Cc Shuah's other email.
Thanks!
I got the recipients list from the get_mainter.pl.
>
> On Tue, 5 May 2020 18:14:45 +0800
> Po-Hsu Lin <po-hsu....@canonical.com> wrote:
>
> > The UNRESOLVED state is much more apporiate than the UNSUPPORTED state
> > for the absence of the test module, as it matches "test was set up
> > incorrectly" situation in the README file.
> >
> > A possible scenario is that the function was enabled (supported by the
> > kernel) but the module was not installed properly, in this case we
> > cannot call this as UNSUPPORTED.
> >
> > This change also make it consistent with other module-related tests
> > in ftrace.
>
> Acked-by: Steven Rostedt (VMware) <rost...@goodmis.org>
>
> Shuah,
>
> Can you take this after Masami gives his ack (if he does that is).
>
> Thanks,
>
> -- Steve
>
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu....@canonical.com>
> > ---
> > .../testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc | 9
> > ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > b/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > index cbd1743..2b82c80e 100644
> > --- a/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > @@ -17,7 +17,14 @@ unsup() { #msg
> > exit_unsupported
> > }
> >
> > -modprobe $MOD || unsup "$MOD module not available"
> > +unres() { #msg
> > + reset_tracer
> > + rmmod $MOD || true
> > + echo $1
> > + exit_unresolved
> > +}
> > +
> > +modprobe $MOD || unres "$MOD module not available"
> > rmmod $MOD
> >
> > grep -q "preemptoff" available_tracers || unsup "preemptoff tracer not
> > enabled"
>
