On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: > From: Nicolas Ferre <nicolas.fe...@microchip.com> > > Use the proper struct device pointer to check if the wakeup flag > and wakeup source are positioned. > Use the one passed by function call which is equivalent to > &bp->dev->dev.parent. > > It's preventing the trigger of a spurious interrupt in case the > Wake-on-Lan feature is used. > > Fixes: bc1109d04c39 ("net: macb: Add pm runtime support")
Fixes tag: Fixes: bc1109d04c39 ("net: macb: Add pm runtime support") Has these problem(s): - Target SHA1 does not exist > Signed-off-by: Nicolas Ferre <nicolas.fe...@microchip.com> > Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > Cc: Claudiu Beznea <claudiu.bez...@microchip.com> > Cc: Harini Katakam <harini.kata...@xilinx.com> > --- > drivers/net/ethernet/cadence/macb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c > b/drivers/net/ethernet/cadence/macb_main.c > index 36290a8e2a84..d11fae37d46b 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -4616,7 +4616,7 @@ static int __maybe_unused macb_runtime_suspend(struct > device *dev) > struct net_device *netdev = dev_get_drvdata(dev); > struct macb *bp = netdev_priv(netdev); > > - if (!(device_may_wakeup(&bp->dev->dev))) { > + if (!(device_may_wakeup(dev))) { > clk_disable_unprepare(bp->tx_clk); > clk_disable_unprepare(bp->hclk); > clk_disable_unprepare(bp->pclk); > @@ -4632,7 +4632,7 @@ static int __maybe_unused macb_runtime_resume(struct > device *dev) > struct net_device *netdev = dev_get_drvdata(dev); > struct macb *bp = netdev_priv(netdev); > > - if (!(device_may_wakeup(&bp->dev->dev))) { > + if (!(device_may_wakeup(dev))) { > clk_prepare_enable(bp->pclk); > clk_prepare_enable(bp->hclk); > clk_prepare_enable(bp->tx_clk);