Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
 drivers/gnss/sirf.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
index effed3a8d398..2ecb1d3e8eeb 100644
--- a/drivers/gnss/sirf.c
+++ b/drivers/gnss/sirf.c
@@ -439,14 +439,18 @@ static int sirf_probe(struct serdev_device *serdev)
 
        data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff",
                        GPIOD_OUT_LOW);
-       if (IS_ERR(data->on_off))
+       if (IS_ERR(data->on_off)) {
+               ret = PTR_ERR(data->on_off);
                goto err_put_device;
+       }
 
        if (data->on_off) {
                data->wakeup = devm_gpiod_get_optional(dev, "sirf,wakeup",
                                GPIOD_IN);
-               if (IS_ERR(data->wakeup))
+               if (IS_ERR(data->wakeup)) {
+                       ret = PTR_ERR(data->wakeup);
                        goto err_put_device;
+               }
 
                ret = regulator_enable(data->vcc);
                if (ret)



Reply via email to