Hi Ansuel,
On Fri, May 01, 2020 at 12:06:11AM +0200, Ansuel Smith wrote:
> Add missing ext reset used by ipq8064 SoC in PCIe qcom driver.
>
> Fixes: 82a823833f4e PCI: qcom: Add Qualcomm PCIe controller driver
> Signed-off-by: Sham Muthayyan <smuth...@codeaurora.org>
> Signed-off-by: Ansuel Smith <ansuels...@gmail.com>
> Cc: sta...@vger.kernel.org # v4.5+
> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c
> b/drivers/pci/controller/dwc/pcie-qcom.c
> index 7a8901efc031..921030a64bab 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
[...]
> @@ -347,6 +353,12 @@ static int qcom_pcie_init_2_1_0(struct qcom_pcie *pcie)
> goto err_deassert_ahb;
> }
>
> + ret = reset_control_deassert(res->ext_reset);
> + if (ret) {
> + dev_err(dev, "cannot assert ext reset\n");
^
This probably should say "cannot deassert ext reset". Apart from this,
Reviewed-by: Philipp Zabel <p.za...@pengutronix.de>
regards
Philipp
