On Wed, 2020-05-06 at 23:00 +0200, Enric Balletbo i Serra wrote: > Hi Weiyi, > > Thank you for your patch. You should cc [email protected], otherwise > this patch might be ignored. >
Got it. > On 6/5/20 10:15, Weiyi Lu wrote: > > Add power dt-bindings of MT8183 and introduces "BASIC" and > > "SUBSYS" clock types in binding document. > > The "BASIC" type is compatible to the original power control with > > clock name [a-z]+[0-9]*, e.g. mm, vpu1. > > The "SUBSYS" type is used for bus protection control with clock > > name [a-z]+-[0-9]+, e.g. isp-0, cam-1. > > And add an optional smi-comm property for phandle to smi-common > > controller. > > > > Signed-off-by: Weiyi Lu <[email protected]> > > --- > > .../devicetree/bindings/soc/mediatek/scpsys.txt | 21 ++++++++++++++--- > > include/dt-bindings/power/mt8183-power.h | 26 > > ++++++++++++++++++++++ > > 2 files changed, 44 insertions(+), 3 deletions(-) > > create mode 100644 include/dt-bindings/power/mt8183-power.h > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > index 2bc3677..5424e66 100644 > > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > @@ -15,6 +15,7 @@ power/power-domain.yaml. It provides the power domains > > defined in > > - include/dt-bindings/power/mt2701-power.h > > - include/dt-bindings/power/mt2712-power.h > > - include/dt-bindings/power/mt7622-power.h > > +- include/dt-bindings/power/mt8183-power.h > > > > Required properties: > > - compatible: Should be one of: > > @@ -27,12 +28,16 @@ Required properties: > > - "mediatek,mt7623a-scpsys": For MT7623A SoC > > - "mediatek,mt7629-scpsys", "mediatek,mt7622-scpsys": For MT7629 SoC > > - "mediatek,mt8173-scpsys" > > + - "mediatek,mt8183-scpsys" > > - #power-domain-cells: Must be 1 > > - reg: Address range of the SCPSYS unit > > - infracfg: must contain a phandle to the infracfg controller > > -- clock, clock-names: clocks according to the common clock binding. > > - These are clocks which hardware needs to be > > - enabled before enabling certain power domains. > > +- clock, clock-names: Clocks according to the common clock binding. > > + Some SoCs have to groups of clocks. > > + BASIC clocks need to be enabled before enabling the > > + corresponding power domain. > > + SUBSYS clocks need to be enabled before releasing the > > + bus protection. > > Required clocks for MT2701 or MT7623: "mm", "mfg", "ethif" > > Required clocks for MT2712: "mm", "mfg", "venc", "jpgdec", "audio", > > "vdec" > > Required clocks for MT6765: MUX: "mm", "mfg" > > @@ -43,6 +48,15 @@ Required properties: > > Required clocks for MT7622 or MT7629: "hif_sel" > > Required clocks for MT7623A: "ethif" > > Required clocks for MT8173: "mm", "mfg", "venc", "venc_lt" > > + Required clocks for MT8183: BASIC: "audio", "mfg", "mm", "cam", "isp", > > + "vpu", "vpu1", "vpu2", "vpu3" > > + SUBSYS: "mm-0", "mm-1", "mm-2", "mm-3", > > + "mm-4", "mm-5", "mm-6", "mm-7", > > + "mm-8", "mm-9", "isp-0", "isp-1", > > + "cam-0", "cam-1", "cam-2", "cam-3", > > + "cam-4", "cam-5", "cam-6", "vpu-0", > > + "vpu-1", "vpu-2", "vpu-3", "vpu-4", > > + "vpu-5" > > > > Optional properties: > > - vdec-supply: Power supply for the vdec power domain > > @@ -55,6 +69,7 @@ Optional properties: > > - mfg_async-supply: Power supply for the mfg_async power domain > > - mfg_2d-supply: Power supply for the mfg_2d power domain > > - mfg-supply: Power supply for the mfg power domain > > +- smi_comm: a phandle to the smi-common controller > > > I think that in device-tree hyphen are preferred and kind of a must for new > properties, also I think you should prefix this property with "mediatek,". > Can I > suggest you to use "mediatek,smi" like is done in the mediatek,smi-larb > binding? > AFAICS is the same phandle right? > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt: > - mediatek,smi : a phandle to the smi_common node. > Thanks, I'll follow your suggestion in next version. > > > > > Example: > > > > diff --git a/include/dt-bindings/power/mt8183-power.h > > b/include/dt-bindings/power/mt8183-power.h > > new file mode 100644 > > index 0000000..d6b25f8 > > --- /dev/null > > +++ b/include/dt-bindings/power/mt8183-power.h > > @@ -0,0 +1,26 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2018 MediaTek Inc. > > You probably want to update the copyright to 2020. > Thanks, I'll fix it. > > + * Author: Weiyi Lu <[email protected]> > > + */ > > + > > +#ifndef _DT_BINDINGS_POWER_MT8183_POWER_H > > +#define _DT_BINDINGS_POWER_MT8183_POWER_H > > + > > +#define MT8183_POWER_DOMAIN_AUDIO 0 > > +#define MT8183_POWER_DOMAIN_CONN 1 > > +#define MT8183_POWER_DOMAIN_MFG_ASYNC 2 > > +#define MT8183_POWER_DOMAIN_MFG 3 > > +#define MT8183_POWER_DOMAIN_MFG_CORE0 4 > > +#define MT8183_POWER_DOMAIN_MFG_CORE1 5 > > +#define MT8183_POWER_DOMAIN_MFG_2D 6 > > +#define MT8183_POWER_DOMAIN_DISP 7 > > +#define MT8183_POWER_DOMAIN_CAM 8 > > +#define MT8183_POWER_DOMAIN_ISP 9 > > +#define MT8183_POWER_DOMAIN_VDEC 10 > > +#define MT8183_POWER_DOMAIN_VENC 11 > > +#define MT8183_POWER_DOMAIN_VPU_TOP 12 > > +#define MT8183_POWER_DOMAIN_VPU_CORE0 13 > > +#define MT8183_POWER_DOMAIN_VPU_CORE1 14 > > + > > +#endif /* _DT_BINDINGS_POWER_MT8183_POWER_H */ > > > > _______________________________________________ > Linux-mediatek mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-mediatek
