On Mon, May 11, 2020 at 8:13 AM Srinivas Kandagatla <srinivas.kandaga...@linaro.org> wrote: > > From: Saravana Kannan <sarava...@google.com> > > When setting the of_node for a newly created device, also set the > fwnode. This allows fw_devlink feature to work for slimbus devices. > > Also, remove some unnecessary NULL checks. The functions in question > already do NULL checks. > > Signed-off-by: Saravana Kannan <sarava...@google.com> > [Srini: removed unnecessary NULL check from other patch] > Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org> > --- > drivers/slimbus/core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c > index 526e3215d8fe..1f3beee74fdf 100644 > --- a/drivers/slimbus/core.c > +++ b/drivers/slimbus/core.c > @@ -162,9 +162,8 @@ static int slim_add_device(struct slim_controller *ctrl, > sbdev->ctrl = ctrl; > INIT_LIST_HEAD(&sbdev->stream_list); > spin_lock_init(&sbdev->stream_list_lock); > - > - if (node) > - sbdev->dev.of_node = of_node_get(node); > + sbdev->dev.of_node = of_node_get(node); > + sbdev->dev.fwnode = of_fwnode_handle(node); > > dev_set_name(&sbdev->dev, "%x:%x:%x:%x", > sbdev->e_addr.manf_id, > -- > 2.21.0
The edits look fine to me. -Saravana
