On Mon 11 May 19:17 PDT 2020, Samuel Zou wrote: > Fix the following sparse warning: > > drivers/iommu/msm_iommu.c:37:1: warning: symbol 'msm_iommu_lock' was not > declared. > > The msm_iommu_lock has only call site within msm_iommu.c > It should be static >
Reviewed-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > Fixes: 0720d1f052dc ("msm: Add MSM IOMMU support") > Reported-by: Hulk Robot <hul...@huawei.com> > Signed-off-by: Samuel Zou <zou_...@huawei.com> > --- > drivers/iommu/msm_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 10cd4db..3d8a635 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -34,7 +34,7 @@ __asm__ __volatile__ ( > \ > /* bitmap of the page sizes currently supported */ > #define MSM_IOMMU_PGSIZES (SZ_4K | SZ_64K | SZ_1M | SZ_16M) > > -DEFINE_SPINLOCK(msm_iommu_lock); > +static DEFINE_SPINLOCK(msm_iommu_lock); > static LIST_HEAD(qcom_iommu_devices); > static struct iommu_ops msm_iommu_ops; > > -- > 2.6.2 >