On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote:
> From: Yufeng Mo <moyuf...@huawei.com>
>
> PHY loopback is already supported by genphy driver. This patch
> adds the set_loopback interface to RTL8211F PHY driver, so the PHY
> selftest can run properly on it.
>
> Signed-off-by: Yufeng Mo <moyuf...@huawei.com>
> Signed-off-by: Jian Shen <shenjia...@huawei.com>
> Signed-off-by: Huazhong Tan <tanhuazh...@huawei.com>
It took three people to write a 1 line patch?
> ---
> drivers/net/phy/realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index c7229d0..6c5918c 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -615,6 +615,7 @@ static struct phy_driver realtek_drvs[] = {
> .resume = genphy_resume,
> .read_page = rtl821x_read_page,
> .write_page = rtl821x_write_page,
> + .set_loopback = genphy_loopback,
> }, {
> .name = "Generic FE-GE Realtek PHY",
> .match_phy_device = rtlgen_match_phy_device,
Do you have access to the data sheets? Can you check if the other PHYs
supported by this driver also support loopback in the standard way?
They probably do.
Andrew
