On Fri, May 15, 2020 at 01:47:53PM +0300, Serge Semin wrote:
> Since there is a generic method available to initialize the DW SPI DMA
> interface on any DT and ACPI-based platforms, which in general can be
> designed with not only DW DMAC but with any DMA engine on board, we can
> freely remove the CONFIG_DW_DMAC_PCI config from dependency list of
> CONFIG_SPI_DW_DMA. Especially seeing that we don't use anything DW DMAC
> specific in the new driver.

Right, and used data structures are always available at compile time.
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>

> Co-developed-by: Georgy Vlasov <georgy.vla...@baikalelectronics.ru>
> Signed-off-by: Georgy Vlasov <georgy.vla...@baikalelectronics.ru>
> Co-developed-by: Ramil Zaripov <ramil.zari...@baikalelectronics.ru>
> Signed-off-by: Ramil Zaripov <ramil.zari...@baikalelectronics.ru>
> Signed-off-by: Serge Semin <sergey.se...@baikalelectronics.ru>
> Cc: Alexey Malahov <alexey.mala...@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbog...@alpha.franken.de>
> Cc: Paul Burton <paulbur...@kernel.org>
> Cc: Ralf Baechle <r...@linux-mips.org>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: Allison Randal <alli...@lohutok.net>
> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Cc: Gareth Williams <gareth.williams...@renesas.com>
> Cc: linux-m...@vger.kernel.org
> Cc: devicet...@vger.kernel.org
> ---
>  drivers/spi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 03b061975f70..6a84f3dad35c 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -228,7 +228,7 @@ config SPI_DESIGNWARE
>  
>  config SPI_DW_DMA
>       bool "DMA support for DW SPI controller"
> -     depends on SPI_DESIGNWARE && DW_DMAC_PCI
> +     depends on SPI_DESIGNWARE
>  
>  config SPI_DW_PCI
>       tristate "PCI interface driver for DW SPI core"
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko


Reply via email to