On Fri, May 15, 2020 at 09:28:33PM +0000, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
>
> Using a taint flag allows us to annotate when this happens clearly.
>
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Cc: Shannon Nelson <snel...@pensando.io>
> Cc: Jakub Kicinski <k...@kernel.org>
> Cc: Heiner Kallweit <hkallwe...@gmail.com>
> Signed-off-by: Luis Chamberlain <mcg...@kernel.org>
> ---
> drivers/net/ethernet/8390/axnet_cs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/8390/axnet_cs.c
> b/drivers/net/ethernet/8390/axnet_cs.c
> index aeae7966a082..8ad0200db8e9 100644
> --- a/drivers/net/ethernet/8390/axnet_cs.c
> +++ b/drivers/net/ethernet/8390/axnet_cs.c
> @@ -1358,9 +1358,11 @@ static void ei_receive(struct net_device *dev)
> */
> if ((netif_msg_rx_err(ei_local)) &&
> this_frame != ei_local->current_page &&
> - (this_frame != 0x0 || rxing_page != 0xFF))
> + (this_frame != 0x0 || rxing_page != 0xFF)) {
> + module_firmware_crashed();
> netdev_err(dev, "mismatched read page pointers %2x vs
> %2x\n",
> this_frame, ei_local->current_page);
> + }
>
> if (this_frame == rxing_page) /* Read all the frames? */
> break; /* Done for now */
> --
> 2.26.2
>
Acked-by: Rafael Aquini <aqu...@redhat.com>
