On Fri, May 15, 2020 at 09:28:34PM +0000, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
> 
> Using a taint flag allows us to annotate when this happens clearly.
> 
> Cc: Ariel Elior <ael...@marvell.com>
> Cc: Sudarsana Kalluru <skall...@marvell.com>
> CC: gr-everest-linux...@marvell.com
> Signed-off-by: Luis Chamberlain <mcg...@kernel.org>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c 
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> index db5107e7937c..c38b8c9c8af0 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> @@ -909,6 +909,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
>       bp->eth_stats.unrecoverable_error++;
>       DP(BNX2X_MSG_STATS, "stats_state - DISABLED\n");
>  
> +     module_firmware_crashed();
>       BNX2X_ERR("begin crash dump -----------------\n");
>  
>       /* Indices */
> -- 
> 2.26.2
> 
Acked-by: Rafael Aquini <aqu...@redhat.com>

Reply via email to