On 2020/5/15 22:45, Jaegeuk Kim wrote: > On 05/15, Chao Yu wrote: >> On 2020/5/15 10:15, Jaegeuk Kim wrote: >>> Let's guarantee flusing dirty meta pages to avoid infinite loop. >> >> What's the root cause? Race case or meta page flush failure? > > Investigating, but at least, this can avoid the inifinite loop there.
Hmm... this fix may cover the root cause.. Thanks, > > V2: > >>From c60ce8e7178004fd6cba96e592247e43b5fd98d8 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim <jaeg...@kernel.org> > Date: Wed, 13 May 2020 21:12:53 -0700 > Subject: [PATCH] f2fs: flush dirty meta pages when flushing them > > Let's guarantee flusing dirty meta pages to avoid infinite loop. > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > --- > fs/f2fs/checkpoint.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 620a386d82c1a..3dc3ac6fe1432 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1266,6 +1266,9 @@ void f2fs_wait_on_all_pages(struct f2fs_sb_info *sbi, > int type) > if (unlikely(f2fs_cp_error(sbi))) > break; > > + if (type == F2FS_DIRTY_META) > + f2fs_sync_meta_pages(sbi, META, LONG_MAX, > + FS_CP_META_IO); > io_schedule_timeout(DEFAULT_IO_TIMEOUT); > } > finish_wait(&sbi->cp_wait, &wait); >
