> From: Anson Huang <[email protected]>
> Sent: Monday, May 18, 2020 1:32 PM
> 
> > Subject: RE: [PATCH] dt-bindings: pwm: Convert mxs pwm to json-schema
> >
> > > +title: Freescale MXS PWM controller
> > > +
> > > +maintainers:
> > > +  - Shawn Guo <[email protected]>
> > > +  - Anson Huang <[email protected]>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - fsl,imx23-pwm
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  "#pwm-cells":
> > > +    const: 3
> >
> > Seems you missed the reference to pwm.yaml.
> 
> It is because many pwm yaml files also has no "#pwm-cells" reference, so I am
> NOT sure if it is a MUST:
> 
> Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
> Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
> ...

I guess we'd better add it.
Let's wait for Rob's feedback.

Regards
Aisheng

> 
> Anson

Reply via email to