On Wed, 20 May, at 11:52:34PM, Jiri Olsa wrote:
> On Wed, May 20, 2020 at 02:00:49PM +0100, Matt Fleming wrote:
> >
> > Nope, the tests in this file are unit tests so I'm testing
> > free_cache_{get,put} which are file-local functions by #include'ing
> > ordered-events.c.
> >
> > The above define are required to avoid duplicate symbol errors at
> > link-time, e.g.
> >
> > util/perf-in.o: In function `ordered_events__flush_time':
> > /home/matt/src/kernels/linux/tools/perf/util/ordered-events.c:461:
> > multiple definition of `ordered_events__flush_time'
> >
> > tests/perf-in.o:/home/matt/src/kernels/linux/tools/perf/tests/../util/ordered-events.c:461:
> > first defined here
> >
> > There are other ways to resolve this (linker flags to change the
> > symbols) but I couldn't find any precedent with that, so this seemed
> > like the easiest and most obvious solution. I'm happy to fix this up any
> > other way if you have suggestions though.
>
> hum, could we just make free_cache_{get,put} public?
Yeah that's totally doable. I'll send a v2 with all these changes.
