On 27/05/20 12:03, Vitaly Kuznetsov wrote: >> >> vcpu->arch.maxphyaddr = cpuid_query_maxphyaddr(vcpu); >> + vcpu->arch.tdp_level = kvm_x86_ops.get_tdp_level(vcpu); >> >> vcpu->arch.pat = MSR_IA32_CR_PAT_DEFAULT; > Reviewed-by: Vitaly Kuznetsov <[email protected]> > > Looking at kvm_update_cpuid() I was thinking if it would make sense to > duplicate the "/* Note, maxphyaddr must be updated before tdp_level. */" > comment here (it seems to be a vmx-only thing btw), drop it from > kvm_update_cpuid() or move cpuid_query_maxphyaddr() to get_tdp_level() > but didn't come to a conclusive answer.
Yeah, it makes sense to at least add the comment here too. Paolo
