On Wed, May 27, 2020 at 09:42:33AM -0700, Matt Helsley wrote:
> @@ -525,16 +556,8 @@ static int read_relocs(struct elf *elf)
> return -1;
> }
> memset(reloc, 0, sizeof(*reloc));
> -
> - if (!gelf_getrela(sec->data, i, &reloc->rela)) {
> - WARN_ELF("gelf_getrela");
> + if (read_reloc(sec, i, reloc, &symndx))
> return -1;
> - }
I try to avoid function pointers, them being slow and ugly and all.
Since it's just a single call site, I'd rather a direct call. For
example, call read_reloc(), which has an if-then to decide which
subfunction to call.
--
Josh
