Hi, Thomas, On Fri, May 29, 2020 at 4:05 PM Thomas Bogendoerfer <[email protected]> wrote: > > On Fri, May 29, 2020 at 09:24:06AM +0800, Huacai Chen wrote: > > Hi, Tiezhu, > > > > On Thu, May 28, 2020 at 4:28 PM Tiezhu Yang <[email protected]> wrote: > > > > > > Replace PTR_STR with INST_PTR_STR to fix the following build warning when > > > CONFIG_TEST_PRINTF is set: > > > > > > CC lib/test_printf.o > > > lib/test_printf.c:214:0: warning: "PTR_STR" redefined > > > #define PTR_STR "ffff0123456789ab" > > > ^ > > > In file included from ./arch/mips/include/asm/dsemul.h:11:0, > > > from ./arch/mips/include/asm/processor.h:22, > > > from ./arch/mips/include/asm/thread_info.h:16, > > > from ./include/linux/thread_info.h:38, > > > from ./include/asm-generic/preempt.h:5, > > > from ./arch/mips/include/generated/asm/preempt.h:1, > > > from ./include/linux/preempt.h:78, > > > from ./include/linux/spinlock.h:51, > > > from ./include/linux/seqlock.h:36, > > > from ./include/linux/time.h:6, > > > from ./include/linux/stat.h:19, > > > from ./include/linux/module.h:13, > > > from lib/test_printf.c:10: > > > ./arch/mips/include/asm/inst.h:20:0: note: this is the location of the > > > previous definition > > > #define PTR_STR ".dword" > > > ^ > > > > > > Fixes: e701656ec4db ("MIPS: inst.h: Stop including asm.h to avoid various > > > build failures") > > > Signed-off-by: Tiezhu Yang <[email protected]> > > Thank you for catching this issue, but I think this is not the best > > solution. Maciej suggest another solution, and I will send a patch to > > fix it. > > thank you, I was about to fix it myself. Not sure about your plan, > but my idea would be to move the unaligned stuff into it's another > or a new header file. Yes, this is also Maciej's suggestion, and I have sent the patch one minute ago...
Huacai > > Thomas. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ]
