On Mon, 01 Jun 2020, Charles Keepax wrote: > On Mon, Jun 01, 2020 at 06:24:33AM +0100, Lee Jones wrote: > > On Fri, 29 May 2020, Charles Keepax wrote: > > > > Still needs a commit log. > > > > > Signed-off-by: Charles Keepax <ckee...@opensource.cirrus.com> > > > --- > > > drivers/mfd/madera-core.c | 12 ++++++------ > > > drivers/mfd/madera-i2c.c | 1 - > > > include/linux/mfd/madera/pdata.h | 1 - > > > 3 files changed, 6 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c > > > index 7e0835cb062b1..4724c1a01a39f 100644 > > > --- a/drivers/mfd/madera-core.c > > > +++ b/drivers/mfd/madera-core.c > > > @@ -44,7 +44,7 @@ static const char * const madera_core_supplies[] = { > > > }; > > > > > > static const struct mfd_cell madera_ldo1_devs[] = { > > > - { .name = "madera-ldo1" }, > > > + { .name = "madera-ldo1", }, > > > > What issue does this solve? > > > > Why are ','s a requirement, even for single entries? > > > > Was more just a consistency thing, we seem to have ended up with > half the lines having commas and half not, happy to move them all > to not having comma's if that is your preference?
I don't have a preference. Consistency is more important to me. Please describe your changes in the commit log. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog