On Tue, Jun 02, 2020 at 06:24:35PM +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > The variable divider is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed.
Right. Thanks. Reviewed-by: Serge Semin <[email protected]> > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/clk/baikal-t1/ccu-div.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/baikal-t1/ccu-div.c b/drivers/clk/baikal-t1/ccu-div.c > index bd40f5936f08..4062092d67f9 100644 > --- a/drivers/clk/baikal-t1/ccu-div.c > +++ b/drivers/clk/baikal-t1/ccu-div.c > @@ -248,7 +248,7 @@ static int ccu_div_var_set_rate_fast(struct clk_hw *hw, > unsigned long rate, > unsigned long parent_rate) > { > struct ccu_div *div = to_ccu_div(hw); > - unsigned long flags, divider = 1; > + unsigned long flags, divider; > u32 val; > > divider = ccu_div_var_calc_divider(rate, parent_rate, div->mask); > -- > 2.25.1 >
