On 2020/6/4 下午2:50, Herbert Xu wrote:
On Thu, Jun 04, 2020 at 02:44:16PM +0800, Zhangfei Gao wrote:
I think it is fine.
1. Currently the name size is 64, bigger enough.
Simply grep in driver name, 64 should be enough.
We can make it larger when there is a request.
2. it does not matter what the name is, since it is just an interface.
cat /sys/class/uacce/hisi_zip-0/flags
cat /sys/class/uacce/his-0/flags
should be both fine to app only they can be distinguished.
3. It maybe a hard restriction to fail just because of a long name.
I think we should err on the side of caution. IOW, unless you
know that you need it to succeed when it exceeds the limit, then
you should just make it fail.
Thanks Herbert
Will add a check after the copy.
strlcpy(interface.name, pdev->driver->name,
sizeof(interface.name));
if (strlen(pdev->driver->name) != strlen(interface.name))
return -EINVAL;
Will resend the fix after rc1 is open.
Thanks
