Em Mon, Jun 08, 2020 at 09:52:43AM -0700, Ian Rogers escreveu: > On Mon, Jun 8, 2020 at 9:18 AM Stephane Eranian <eran...@google.com> wrote: > A lot of the complexity in this code came from strbuf not \0 > terminating strings. Would a strbuf that always \0 terminated be a > useful change? In general there's a lack of consistent style with > strbuf, strcat and asprintf being used in different parts of the code. > Perhaps strbuf use should migrate to asprintf? There are currently
I think that going to asprintf is best, this came from long ago, when perf reused parts of the git sources as a starting point. > just 13 callers of strbuf_init. - Arnaldo
