Avri: Please review!

> When ufs_bsg_alloc_desc_buffer() returns an error code,
> a pairing runtime PM usage counter decrement is needed
> to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao....@zju.edu.cn>
> ---
>  drivers/scsi/ufs/ufs_bsg.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
> index 53dd87628cbe..516a7f573942 100644
> --- a/drivers/scsi/ufs/ufs_bsg.c
> +++ b/drivers/scsi/ufs/ufs_bsg.c
> @@ -106,8 +106,10 @@ static int ufs_bsg_request(struct bsg_job *job)
>               desc_op = bsg_request->upiu_req.qr.opcode;
>               ret = ufs_bsg_alloc_desc_buffer(hba, job, &desc_buff,
>                                               &desc_len, desc_op);
> -             if (ret)
> +             if (ret) {
> +                     pm_runtime_put_sync(hba->dev);
>                       goto out;
> +             }
>  
>               /* fall through */
>       case UPIU_TRANSACTION_NOP_OUT:

-- 
Martin K. Petersen      Oracle Linux Engineering

Reply via email to